molgenis / molgenis-ui-context

The menu component of MOLGENIS
GNU Lesser General Public License v3.0
0 stars 7 forks source link

refactor: move top log style from js to css #49

Closed connoratrug closed 5 years ago

connoratrug commented 5 years ago

Use of style is static within component therefore dynamic ( js ) usage is overly complex and can be replaced with style rule.

Checklist

codecov[bot] commented 5 years ago

Codecov Report

Merging #49 into master will decrease coverage by 0.1%. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #49     +/-   ##
========================================
- Coverage    87.6%   87.5%   -0.2%     
========================================
  Files          11      11             
  Lines          97      96      -1     
  Branches       13      12      -1     
========================================
- Hits           85      84      -1     
  Misses         12      12
Flag Coverage Δ
#unit 87.5% <ø> (-0.2%) :arrow_down:
Impacted Files Coverage Δ
src/components/NavBar.vue 80% <ø> (-0.5%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a9083b5...46b8e6e. Read the comment docs.

molgenis-jenkins commented 5 years ago

:tada: This PR is included in version 1.1.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: