molgenis / molgenis-ui-context

The menu component of MOLGENIS
GNU Lesser General Public License v3.0
0 stars 7 forks source link

fix: add missing citation #8423 #63

Closed MaxPostema closed 5 years ago

MaxPostema commented 5 years ago

fixes: https://github.com/molgenis/molgenis/issues/8423

Removed dependency on molgenis (/app-ui-context) Getting URL's externally from a static source (molgenis/molgenis-core-ui/src/main.recources/js/bootstrap-4/footer/molgenis-footer.js?) but having the text locally static obfuscates without having a clear reason.

Checklist

codecov[bot] commented 5 years ago

Codecov Report

Merging #63 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #63   +/-   ##
======================================
  Coverage    89.4%   89.4%           
======================================
  Files          13      13           
  Lines         104     104           
  Branches       13      13           
======================================
  Hits           93      93           
  Misses         11      11
Flag Coverage Δ
#unit 89.4% <ø> (ø) :arrow_up:
Impacted Files Coverage Δ
src/components/FooterComponent.vue 100% <ø> (ø) :arrow_up:
src/exampleFooter.ts 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eebf7f6...6317eb9. Read the comment docs.

molgenis-jenkins commented 5 years ago

:tada: This PR is included in version 1.2.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: