Closed fdlk closed 5 years ago
I'm not clear on why we want to call Vue.extend. I do know why we don't want to do it, because it means the library depends on Vue. So unless there's a clear need, I'd like to try doing without.
Merging #66 into master will decrease coverage by
0.3%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #66 +/- ##
========================================
- Coverage 89.4% 89.1% -0.4%
========================================
Files 13 12 -1
Lines 104 101 -3
Branches 13 13
========================================
- Hits 93 90 -3
Misses 11 11
Flag | Coverage Δ | |
---|---|---|
#unit | 89.1% <ø> (-0.4%) |
:arrow_down: |
Impacted Files | Coverage Δ | |
---|---|---|
src/components/DropDownItems.vue | 100% <ø> (ø) |
:arrow_up: |
src/components/CookieWall.vue | 90% <ø> (-1%) |
:arrow_down: |
src/components/NavBar.vue | 82.5% <ø> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 4c5e423...8add459. Read the comment docs.
:tada: This PR is included in version 1.3.1 :tada:
The release is available on:
npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:
Please describe the issue that is being 'fixed' here ( and link it), what is expected and the observed behaviour.
Vue.extend adds typing support for typescript and IDE, see view doc on using extend and connection with typescript support.
It is a dev dependency
Checklist