search

molgenis / molgenis-ui-context

The menu component of MOLGENIS
GNU Lesser General Public License v3.0
0 stars 7 forks source link

fix: force ts setTimeout definition from window #85

Closed jvanveen closed 4 years ago

jvanveen commented 4 years ago

For more info, see https://github.com/mgechev/angular-seed/issues/901

Checklist

jvanveen commented 4 years ago

Dit ging mis in de typescript compiler op het moment dat ik nodejs type definities toevoegde aan de lifelines repo. Node.js heeft ook een setTimeout functie en die gebruikt net even andere types. Fix is door expliciet de window property aan te roepen.

codecov[bot] commented 4 years ago

Codecov Report

Merging #85 into master will decrease coverage by 0.8%. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #85     +/-   ##
======================================
- Coverage    90.8%   90%   -0.9%     
======================================
  Files          13    13             
  Lines         109   110      +1     
  Branches       12    13      +1     
======================================
  Hits           99    99             
- Misses         10    11      +1
Flag Coverage Δ
#unit 90% <100%> (-0.9%) :arrow_down:
Impacted Files Coverage Δ
src/service/EventUtilService.ts 84.6% <100%> (ø) :arrow_up:
src/repository/LanguageRepository.ts 85.7% <0%> (-14.3%) :arrow_down:
src/exampleMenu.ts 100% <0%> (ø) :arrow_up:
src/components/NavBar.vue 82.5% <0%> (+0.4%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cb3ac44...f647490. Read the comment docs.

marikaris commented 4 years ago

Maybe next time it's better to fork the repository and make the branch on your own fork. Other than that the fix is ok.

molgenis-jenkins commented 4 years ago

:tada: This PR is included in version 1.4.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: