molgenis / molgenis-ui-context

The menu component of MOLGENIS

GNU Lesser General Public License v3.0

0 stars 7 forks source link

[FEAT] add vuex module #87

Closed fdlk closed 4 years ago

fdlk commented 4 years ago

Checklist

[x] Functionality works & meets specifications
[x] Code reviewed
[x] Code unit/integration/system tested
[x] User documentation updated
[x] Clean commits
[x] No warnings during install
[x] Added Feature/Fix to release notes

connoratrug commented 4 years ago

Suggest to move footer fix to separate PR, this seems like quick fix/check

done

codecov[bot] commented 4 years ago

Codecov Report

Merging #87 into master will increase coverage by 2.2%. The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #87     +/-   ##
======================================
+ Coverage    90.8%   93%   +2.2%     
======================================
  Files          13    18      +5     
  Lines         109   144     +35     
  Branches       13    20      +7     
======================================
+ Hits           99   134     +35     
  Misses         10    10

Flag	Coverage Δ
#unit	`93% <100%> (+2.2%)`	:arrow_up:

Impacted Files	Coverage Δ
src/store/getters.ts	`100% <100%> (ø)`
src/store/mutations.ts	`100% <100%> (ø)`
src/store/actions.ts	`100% <100%> (ø)`
tests/unit/fixtures/context.ts	`100% <100%> (ø)`
src/store/state.ts	`100% <100%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5d63ea0...6b78f37. Read the comment docs.

codecov-io commented 4 years ago

Codecov Report

Merging #87 into master will increase coverage by 2.2%. The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #87     +/-   ##
======================================
+ Coverage    90.8%   93%   +2.2%     
======================================
  Files          13    18      +5     
  Lines         109   144     +35     
  Branches       13    20      +7     
======================================
+ Hits           99   134     +35     
  Misses         10    10

Flag	Coverage Δ
#unit	`93% <100%> (+2.2%)`	:arrow_up:

Impacted Files	Coverage Δ
src/store/getters.ts	`100% <100%> (ø)`
src/store/mutations.ts	`100% <100%> (ø)`
src/store/actions.ts	`100% <100%> (ø)`
tests/unit/fixtures/context.ts	`100% <100%> (ø)`
src/store/state.ts	`100% <100%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5d63ea0...74f0f0f. Read the comment docs.

molgenis-jenkins commented 4 years ago

:tada: This PR is included in version 1.5.0 :tada:

The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: