App setting 'Custom javascript headers' ignored by Vue plugins

dennishendriksen commented 6 years ago

How to Reproduce

As superuser navigate to the 'Settings' plugin in the 'Admin' menu
Set value 'https://molgenis26.gcc.rug.nl/downloads/row-click.js' for 'Custom javascript headers' and save changes
Navigate to 'Navigator' plugin in the main menu

Expected behavior

row-click.js is loaded

Observed behavior

row-click.js is not loaded

mswertz commented 4 years ago

Why is this important -> what is the business case that is now broken?

dennishendriksen commented 4 years ago

Why is this important

For users: their MOLGENIS could break For data managers: it is confusing that your custom JavaScript is only available in same menu items and not in others For developers: people regularly run into this issue, quite a bit of time is spend on determining that the cause is this existing issue.

what is the business case that is now broken?

The usages of the feature that I know include the inclusion of D3 JavaScript (https://wiki.gcc.rug.nl/ticket/4194) or loading scripts to work around other issues.

molgenis / molgenis-ui-context