Sort order for reference columns always sorts on ID

molgenis / molgenis

MOLGENIS - for scientific data: management, exploration, integration and analysis.

https://molgenis.org

GNU Lesser General Public License v3.0

111 stars 99 forks source link

Sort order for reference columns always sorts on ID #6268

Open esthervanenckevort opened 7 years ago

esthervanenckevort commented 7 years ago

How to Reproduce

Go to the BBMRI-ERIC directory 3.1
Click on the Biobank column header to sort by Biobank

Expected behavior

Collections are sorted by Biobank

Observed behavior

Biobanks are not correctly sorted

fdlk commented 7 years ago

It probably sorts on ID, and you would like for it to sort on label?

esthervanenckevort commented 7 years ago

Op 22 jun. 2017, om 14:08 heeft Fleur Kelpin notifications@github.com het volgende geschreven:

It probably sorts on ID, and you would like for it to sort on label?

Since the label is what you see, that would be the expected behaviour.

dennishendriksen commented 7 years ago

The resulting data explorer query is of the form /api/v2/eu_bbmri_eric_collections?sort=biobank. REST API v2 doesn't allow queries such as /api/v2/eu_bbmri_eric_collections?sort=biobank.name and probably it will require some work to propagate such a sort to the database or index.

mswertz commented 5 years ago

is this now irrelevant given sort options we have now?

fdlk commented 5 years ago

@mswertz I think it's still relevant in the data explorer and the query api

dennishendriksen commented 3 years ago

Reported by a colleague of @cpavanrun in 8.4.1