search

molgenis / vibe

Variant Interpretation using Biomedical literature Evidence
GNU Lesser General Public License v3.0
0 stars 5 forks source link

Duplicate counts SPARQL query fix. #48

Open svandenhoek opened 4 years ago

svandenhoek commented 4 years ago

Fix for duplicate counts when the same Disease is found multiple times through different routes.

Retrieving all the UMLS IDs from HPO-terms is now handled through a DISTINCT subquery, removing any duplicates in case the same UMLS was found through multiple UNION routes.

svandenhoek commented 4 years ago

I'm not a SPARQL expert so it is hard for now to judge whether your changes are good. I do think your changes should be accompanied by a test that fails before the changes and succeeds after the changes.

Agreed.

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 2 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication