molgenis / vibe

Variant Interpretation using Biomedical literature Evidence
GNU Lesser General Public License v3.0
0 stars 5 forks source link

vibe-core logging api implementation needs to be removed #57

Open svandenhoek opened 4 years ago

svandenhoek commented 4 years ago

Currently, when using vibe-core as dependency and a different logging bridge is used, exclusions are needed. A fix is needed where vibe-core only uses a logging api interface.

Needed code when using as library that uses different logging bridge:

<dependency>
  <groupId>org.molgenis</groupId>
  <artifactId>vibe-core</artifactId>
  <version>${vibe.version}</version>
  <exclusions>
    <exclusion>
      <groupId>org.slf4j</groupId>
      <artifactId>jcl-over-slf4j</artifactId>
    </exclusion>
    <exclusion>
      <groupId>org.slf4j</groupId>
      <artifactId>slf4j-nop</artifactId>
    </exclusion>
  </exclusions>
</dependency>

Vibe-core maven dependency tree (stripped to relevant parts only):

[INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @ vibe-core ---
[INFO] org.molgenis:vibe-core:jar:4.1.0-SNAPSHOT
[INFO] +- org.slf4j:slf4j-nop:jar:1.7.29:compile
[INFO] |  \- org.slf4j:slf4j-api:jar:1.7.29:compile
[INFO] +- org.apache.jena:apache-jena-libs:pom:3.13.1:compile
[INFO] |  +- org.apache.jena:jena-shacl:jar:3.13.1:compile
[INFO] |  |  \- org.apache.jena:jena-arq:jar:3.13.1:compile
[INFO] |  |     +- org.slf4j:jcl-over-slf4j:jar:1.7.26:compile

Error thrown by molgenis-app-vibe if exclusions are not present:

[INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (enforce-banned-dependencies) @ molgenis-app-vibe ---
[WARNING] Rule 0: org.apache.maven.plugins.enforcer.BannedDependencies failed with message:
Found Banned Dependency: org.slf4j:jcl-over-slf4j:jar:1.7.25
Use 'mvn dependency:tree' to locate the source of the banned dependencies.