molgenis / vibe

Variant Interpretation using Biomedical literature Evidence
GNU Lesser General Public License v3.0
0 stars 5 forks source link

Feature/json streaming #87

Closed svandenhoek closed 3 years ago

svandenhoek commented 3 years ago

Changes

Important notes

GeneDiseaseCollectionSerializer and GeneDiseaseCollectionDeserializer are now simply children of newly implemented classes without any additional code. As these new classes give the same output (except a slight re-ordering of what is written in the output first), this shouldn't cause any major issues (old tests still succeed after adjusting the validation String that the json format stores the combinations after the genes/diseases/sources).

When a new major release is done, deprecated code should be removed.

Checklists

Please update the checklists when steps are completed.

Before merge
After merge
sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

95.0% 95.0% Coverage
1.5% 1.5% Duplication

svandenhoek commented 3 years ago
1. Could you take a look at the code smells reported by Sonar?

All code smells fixed except (duplicate code in) @deprecated classes/methods.

2. Why introduce deprecated code instead of removing it immediately?

To adhere to semantic version so we don't have to make yet another major release yet.