Closed svandenhoek closed 3 years ago
Kudos, SonarCloud Quality Gate passed!
1. Could you take a look at the code smells reported by Sonar?
All code smells fixed except (duplicate code in)
@deprecated
classes/methods.2. Why introduce deprecated code instead of removing it immediately?
To adhere to semantic version so we don't have to make yet another major release yet.
Changes
@deprecated
5.2.0-SNAPSHOT
gson
Important notes
GeneDiseaseCollectionSerializer
andGeneDiseaseCollectionDeserializer
are now simply children of newly implemented classes without any additional code. As these new classes give the same output (except a slight re-ordering of what is written in the output first), this shouldn't cause any major issues (old tests still succeed after adjusting the validation String that the json format stores the combinations after the genes/diseases/sources).When a new major release is done, deprecated code should be removed.
Checklists
Please update the checklists when steps are completed.
Before merge
After merge