molikd / otb

Only The Best (Genome Assembly Tools)
Other
5 stars 3 forks source link

Pipeline not starting scaffolding steps due to missing --scaffold flag #62

Closed dluecke closed 3 months ago

dluecke commented 5 months ago

When starting an OTB run via otb.sh ... --yahs the pipeline doesn't reach scaffolding associated steps (eg process yahs_faidx and process hicstuff) because the value params.scaffold = false isn't modified. otb.sh does not have a line to add the --scaffold flag to the RUN="nextflow run run.nf " string. Adding --scaffold ... -resume to the nextflow run command and resubmitting to SLURM allows the run to reach scaffolding and further steps.

An easy way to resolve this problem would be changing line 332 of otb.sh from [ -n "$YAHS" ] && RUN+="--yahs " to [ -n "$YAHS" ] && RUN+="--scaffold --yahs "

Thank you!

molikd commented 3 months ago

also be fixed in #64