search

molke-productions / qloud

Tool to measure loudspeaker frequency and step responses and distortions
GNU General Public License v2.0
28 stars 6 forks source link

Cleanup #14

Closed molke-productions closed 3 years ago

molke-productions commented 4 years ago

Some minor clean-up for the Qt Charts version.

be1 commented 3 years ago

@molke-productions you're right. Octave output would be too far. I've just pushed removing of the octave button, letting the code underneath for reference...

Maybe it is useless to keep ocatve output generation code. I suggest to remove that part of hidden code.

molke-productions commented 3 years ago

Sorry for the delay. That part should already be removed in the pull request. If you find some time to check that this modified version of your additions still works as expected, then I will go ahead and try to merge this into the master branch.

be1 commented 3 years ago

Thanks molke, sorry for the loong delay. You could merge safely by yourself.

be1 commented 3 years ago

Should we make a tag for this version ?

molke-productions commented 3 years ago

Thanks for checking and merging. As far as I can tell, there seems to be no new functionality or major redesign, so maybe a minor version step like 1.4.1?

be1 commented 3 years ago

Yes, I think 1.4.1 is a good tag. Do you agree if I do it ?

molke-productions commented 3 years ago

Sure, I agree.