search

moll / js-must

An assertion library for JavaScript and Node.js with a friendly BDD syntax (awesome.must.be.true()). It ships with many expressive matchers and is test runner and framework agnostic. Follows RFC 2119 with its use of MUST. Good stuff and well tested.
Other
336 stars 35 forks source link

- Fixed docs and tests not considering NaN as falsy #57

Closed dzek69 closed 3 years ago

dzek69 commented 7 years ago

So, you've missed the fact NaN is falsy too. This fixes the docs and adds test case for NaN.

moll commented 7 years ago

Hey! Thank you for noticing and sorry for the belated response! Do you mind undoing all of the stripped trailing whitespace so I could merge your commit in as-is? The whitespace is there for Markdown. ;) If you can't be bothered, I'll just copy-paste the necessary bits and attribute you in the CHANGELOG. :)

dzek69 commented 3 years ago

haha, finally, after over 3 years, and 3 pushes i've managed to fix that :D looks like my IDE with .editorconfig without trim_trailing_whitespace does that (treats trim_trailing_whitespace as true by default)

anyway. I know this change is not needed as project is probably anbandoned, but I still wanted to ask you - how are you? Have you ever thought about bringing this project back to life, add TypeScript support and stuff? i still consider must the best assertion library I know and I'm using it for all personal stuff

moll commented 3 years ago

Hey again!

Must.js isn't actually abandoned. I've just been occupied with other projects. Fortunately Must.js is also rather stable and relatively feature-complete, apart from some bits and pieces that could be tweaked or added. I'm still using it day-to-day and will all of my new projects. I'm glad you like it, too. :)

Thanks for updating your tweaks, too! I merged them in and put a note in the CHANGELOG. I should really now go over the other issues and a few pull requests. I've got a tendency to procrastinate. ^_^

add TypeScript support

I'd be more than happy to get any help with TypeScript. I've tried using TypeScript now and then, but I find it's not very welcoming of my mostly ES5 code. It insists that I rewrite my plain objects in class syntax, for example, and I'm not a fan of that. If you do use TypeScript and Must.js together, let me know! I'll now go check one of those PRs that refer to TypeScript, too.

Thanks again and talk laters!

dzek69 commented 3 years ago

If you consider Must.js as a feature complete and stable maybe it's time to release as 1.0.0? :)

In previous company we had a policy of reviewing used packages from time to time. Extra "suspicious" points were given to packages that:

So I had to fight to keep using Must.js ;)

If you do use TypeScript and Must.js together, let me know

Actually I am not. I am currently starting with TypeScript and building myself a boilerplate with config that is not bad for existing standards and with favourites packages for tests, docs, linting included.

It insists that I rewrite my plain objects in class syntax, for example

You can keep the code and just add TypeScript type definitions into the package, this way it shouldn't bother you :)

I've got a tendency to procrastinate. ^_^

I don't know why, but this sounds familiar, see this PR history :D Anyway, after I deal with other stuff I always wanted to do but never finished I may take another look at this lib and your work progress and may open another PR with some TS stuff.