Misleading words about should.js in README

moll / js-must

An assertion library for JavaScript and Node.js with a friendly BDD syntax (awesome.must.be.true()). It ships with many expressive matchers and is test runner and framework agnostic. Follows RFC 2119 with its use of MUST. Good stuff and well tested.

Other

336 stars 35 forks source link

Misleading words about should.js in README #60

Open btd opened 7 years ago

btd commented 7 years ago

Hello.

I am a should.js maintainer and everything you described in README was covered in should.js even before must.js was created. Could you please remove should.js parts to do not mislead users?

moll commented 7 years ago

So everything is a function now in Should.js? I'm quite certain back in the day the foo.should.be.false assertion-style existed.

btd commented 7 years ago

Yes, i know about such problem, i was thinking about it almost from begining of maintainance. I tried a lot of things first to avoid breaking change (like adding plugins to jshtin/eslint, proxies to assert on non existing propety access), but eventually decide to make this breaking change - nobody complained about it.

moll commented 7 years ago

That's good. Since what version did you fix this? I'll make a note of that in the README that what I said applies only to previous versions. ;)

btd commented 7 years ago

It is safe to assume since 7.0.0 (current 11.x.y). Thanks.