search

moll / js-must

An assertion library for JavaScript and Node.js with a friendly BDD syntax (awesome.must.be.true()). It ships with many expressive matchers and is test runner and framework agnostic. Follows RFC 2119 with its use of MUST. Good stuff and well tested.
Other
336 stars 35 forks source link

Print actual exception stack trace on 'throw' assertion fail #7

Closed koresar closed 8 years ago

koresar commented 10 years ago

In my dev environment the console output looks just perfect. See below.

AssertionError: function () { [native code] } must throw /_types/ but threw
Error: use valid cql types while declaring columns in TABLE
Error
at FluentCql.setError (C:\code\fcql\lib\fluent-cql.js:63:43)
at FluentCql._columns (C:\code\fcql\lib\fluent-cql.js:388:25)
at FluentCql._table (C:\code\fcql\lib\fluent-cql.js:360:81)
at FluentCql.table (C:\code\fcql\lib\fluent-cql.js:343:38)
at C:\code\fcql\lib\builder.js:17:29
at ...
koresar commented 10 years ago

And my code breaks many unit tests. Diggin in. Sorry. Again.

moll commented 10 years ago

Hey, big thanks for the help again! I'll review this as soon as I can. :-)

Btw, you can use Git's amend feature to combine commits that should be a single unit. That helps get rid of those "Fix of fix of fix of last commit" style commits. :-)

koresar commented 10 years ago

Hi. I'm aware of 'amend', but quite lazy to start the git shell. Will do next time. :-)

BTW, I didn't put any tests on the new code, just made sure old don't fail. Frankly speaking I spent some time thinking of where and how to embed new tests, but couldn't find the way fast. Sorry about that. On Jan 10, 2014 8:18 PM, "Andri Möll" notifications@github.com wrote:

Hey, big thanks for the help again! I'll review this as soon as I can. :-)

Btw, you can use Git's amend feature to combine commits that should be a single unit. That helps get rid of those "Fix of fix of fix of last commit" style commits. :-)

— Reply to this email directly or view it on GitHubhttps://github.com/moll/js-must/pull/7#issuecomment-32012912 .

moll commented 10 years ago

I'll be refactoring those tests soon to be more like contract tests. The current integration style doesn't scale very well — too repetitive occasionally.

moll commented 10 years ago

Which Git GUI are you using?

koresar commented 10 years ago

GitExtensions, Sourcetree, Github for Windows, and sometimes git shell. Depends on project and needs. Why? On Jan 10, 2014 8:26 PM, "Andri Möll" notifications@github.com wrote:

Which Git GUI are you using?

— Reply to this email directly or view it on GitHubhttps://github.com/moll/js-must/pull/7#issuecomment-32013324 .

moll commented 10 years ago

Just curious. I'm on Tower and Sourcetree (besides CLI) here.

koresar commented 8 years ago

Two years later this looks like not needed any more. Closing.