search

moll / node-mitm

Intercept and mock outgoing Node.js network TCP connections and HTTP requests for testing. Intercepts and gives you a Net.Socket, Http.IncomingMessage and Http.ServerResponse to test and respond with. Super useful when testing code that hits remote servers.
Other
636 stars 48 forks source link

Avoid using Mocha contexts for variables #18

Closed jupiter closed 9 years ago

jupiter commented 9 years ago

https://github.com/mochajs/mocha/issues/1195#issuecomment-96410059

moll commented 9 years ago

Hey,

Thanks for the patch, though would you mind clarifying, why not use context properties? Wouldn't you say they're more suited for the job?

jupiter commented 9 years ago

I just replied on the original thread here https://github.com/mochajs/mocha/issues/1195#issuecomment-96410059, which hopefully makes sense.

moll commented 9 years ago

Would you feel terrible if I closed this pull request? Like we agreed in https://github.com/mochajs/mocha/issues/1195 I too would prefer Mocha be fixed than work around it.

jupiter commented 9 years ago

Not at all. Was really just an example.