Broken on node 8.12.x and 9.x

moll / node-mitm

Intercept and mock outgoing Node.js network TCP connections and HTTP requests for testing. Intercepts and gives you a Net.Socket, Http.IncomingMessage and Http.ServerResponse to test and respond with. Super useful when testing code that hits remote servers.

Other

637 stars 48 forks source link

Broken on node 8.12.x and 9.x #52

Closed alexkwolfe closed 5 years ago

alexkwolfe commented 5 years ago

A node bug is causing the library to break on 8.12.x and 9.x. As of today, the last compatible version of node is 8.11.4.

I ran the build on travis with all 8.x minor versions: https://travis-ci.org/alexkwolfe/node-mitm/builds/427762391

I tried to sort out whether this was possible to fix for node 8.12.x and 9 so I could open a PR, but it wasn't obvious to me if this bug could be circumvented without the fix in node core.

alexkwolfe commented 5 years ago

Oops. Duplicate of https://github.com/moll/node-mitm/issues/48.