search

moll / node-mitm

Intercept and mock outgoing Node.js network TCP connections and HTTP requests for testing. Intercepts and gives you a Net.Socket, Http.IncomingMessage and Http.ServerResponse to test and respond with. Super useful when testing code that hits remote servers.
Other
637 stars 48 forks source link

node 10.15.1: TypeError: this._handle.shutdown is not a function #57

Closed papandreou closed 5 years ago

papandreou commented 5 years ago

Here we go again. Upgrading from node.js 10.15.0 to 10.15.1 causes error in my test suite:

     Uncaught TypeError: this._handle.shutdown is not a function
      at Socket._final (net.js:361:26)
      at callFinal (_stream_writable.js:612:10)
      at process._tickCallback (internal/process/next_tick.js:63:19)

It can also be reproduced with the node-mitm test suite, 4 tests fail like that.

moll commented 5 years ago

Thx. On it!

moll commented 5 years ago

I'll have to wait a little for https://www.archlinux.org/packages/community/x86_64/nodejs-lts-dubnium/ to reach mirrors before I could verify my fix (which would probably be merely revealing the existing shutdown function to Node v10.5.1).

moll commented 5 years ago

Threw Mitm v1.7 up with support for Node v10.15.1.