Closed nfischer closed 6 years ago
<3
You reckon you can throw in a test for it, too? Thanks!
Sure! I'll take a look. Shouldn't be too hard.
Also, it looks like the CI failed, but it doesn't seem like it's due to my change. Perhaps it's a change in travis?
Ugh, Travis. Why can't some things just remain as they are. -_- I'll get at it before merging. ;)
Update: I realized the issue was I forget setlocal
(readonly is local by default, modifiable is however not). I added the other test back in, and it all passes the unit tests for me (so this should be good to merge, once the CI is fixed).
I tried a couple things for travis, but couldn't figure out a solution. I'll open another issue for it and post what I had.
Hey, why'd you close it?
I don't intend to continue working on this PR. You may land a similar patch if you're interested. Thanks for an excellent plugin :tada:
Core modules (that get downloaded via URL) are now opened in readonly mode.
Fixes #30