search

moll / vim-node

Tools and environment to make Vim superb for developing with Node.js. Like Rails.vim for Node.
http://www.vim.org/scripts/script.php?script_id=4674
Other
807 stars 59 forks source link

fix: core modules are opened readonly #31

Closed nfischer closed 6 years ago

nfischer commented 8 years ago

Core modules (that get downloaded via URL) are now opened in readonly mode.

Fixes #30

moll commented 8 years ago

<3

You reckon you can throw in a test for it, too? Thanks!

nfischer commented 8 years ago

Sure! I'll take a look. Shouldn't be too hard.

Also, it looks like the CI failed, but it doesn't seem like it's due to my change. Perhaps it's a change in travis?

moll commented 8 years ago

Ugh, Travis. Why can't some things just remain as they are. -_- I'll get at it before merging. ;)

nfischer commented 8 years ago

Update: I realized the issue was I forget setlocal (readonly is local by default, modifiable is however not). I added the other test back in, and it all passes the unit tests for me (so this should be good to merge, once the CI is fixed).

I tried a couple things for travis, but couldn't figure out a solution. I'll open another issue for it and post what I had.

moll commented 6 years ago

Hey, why'd you close it?

nfischer commented 6 years ago

I don't intend to continue working on this PR. You may land a similar patch if you're interested. Thanks for an excellent plugin :tada: