search

mollie / Magento

Mollie Payments for Magento 1.x
https://www.mollie.com/
BSD 2-Clause "Simplified" License
39 stars 30 forks source link

Update config.xml #190

Closed randomresult closed 3 years ago

randomresult commented 3 years ago

Remove wrong sorting as tax_subtotal can not be sorted before tax_subtotal. This results in a Circular dependecy when working with a fixed sorting for checkout totals in M1

Marvin-Magmodules commented 3 years ago

Hello @randomresult, Thanks for creating this pull request. Unfortunately, we cannot accept this PR. This sorting is added as it is required to make the calculation correct for the payment fee subtotal. If you still require that this total is removed, you can achieve this by creating a custom module that depends on the Mollie_Mpm module and changes this same node. That way it should override this setting for your case.