search

mollie / OpenCart

iDEAL, Creditcard, Bancontact/Mister Cash, SOFORT, Belfius Direct Net, KBC/CBC Payment Button, Bank transfer, Bitcoin, PayPal & paysafecard for OpenCart 1.5.6+ and OpenCart 2.0+.
http://www.mollie.com
BSD 2-Clause "Simplified" License
72 stars 37 forks source link

Check if $client is initialized #214

Closed osworx closed 4 years ago

osworx commented 4 years ago

https://github.com/mollie/OpenCart/blob/cce5b4d9e5521a0e55cc5480f5acacdb44466f3b/admin/controller/payment/mollie/base.php#L920

Because the extension can be closed without saving an API key (or an invalid like a space), opening the next time results in an error:

Notice: Undefined variable: client in admin\controller\payment\mollie\base.php on line 922

To avoid that, simply add a isset($client) to that.

Or check the fields before the extension can be closed/saved.

QualityWorks commented 4 years ago

this will be fixed in the next release