New names/aliases in Mollie::methods

[muyncky]

Hi,

Thanks for the frequent updates!

I was wondering the implications of the changes in the static array $methods. Currently it contains:

    /** @var array $methods */
    public static $methods = array(
        'banktransfer' => 'Bank',
        'belfius '     => 'Belfius',
        'bitcoin '     => 'Bitcoin',
        'creditcard'   => 'Credit Card',
        'directdebit'  => 'Direct Debit',
        'eps'          => 'EPS',
        'giftcard'     => 'Giftcard',
        'giropay'      => 'Giropay',
        'ideal'        => 'iDEAL',
        'inghomepay '  => 'ING Homepay',
        'kbc'          => 'KBC',
        'bancontact'   => 'Bancontact',
        'paypal'       => 'PayPal',
        'paysafecard'  => 'Paysafecard',
        'sofort'       => 'Sofort Banking',
    );

Two question:

1. The is a space at the end of the string 'belfius ' and 'bitcoin ', is this correct?
2. If we change one of the names, what are the implications? For example: 'banktransfer' => 'Bankoverschrijving'

Thank you for your time.

[snowycatsoftware]

Hi @muyncky ,

Thank you for pointing this out to us! If you want to alter the name of a payment method, the best way is to adjust the translations. If you open the config page of the Mollie module, you will see the "translations" button on the top-right of your screen. Choose Dutch. Underneath the "Module mollie" translation column, you will find the field for translationg banktransfer.

We updated the mollie.php file to fix the whitespace. We will release a new version in the near future. We are currently working on a new upgrade so this will be fixed in the new release as well.

We will close this issue for now. If you have any more questions, you can still post them in this issue.

Kind Regards

[muyncky]

Hi @snowycatsoftware,

If we translate it, will this translation also appear in the orders tabel, like in the example:

[snowycatsoftware]

Hi @muyncky ,

Which version of prestashop are you currently using? Because these fields should already be translated automatically.

Regards

[muyncky]

We want the payment method not to change in the order. There is a webservice who uses, for example, banktransfer as a reference. It's therefor important that this remains so.

PrestaShop version: 1.6.0.14

[snowycatsoftware]

Hi @muyncky ,

If the module has to be altered in order to comply with a external webservice // module, this would be custom work. We can only provide support on issues with the Mollie module. If you want to have the module altered to your specific needs, it's best to hire a developer to customize the module.

If this only applies to the Banktransfer module, maybe using the standard module provided with PrestaShop would solve this problem.

Regards

[muyncky]

We are developers. Changing the names seems to work fine for 3 days now. We will make an override since translation doesn't affect ps_orders.payment, to avoid trouble in future updates.