search

mollie / PrestaShop

iDEAL, Creditcard, Bancontact, SOFORT, Bank transfer, PayPal & paysafecard for Prestashop
http://www.mollie.com
BSD 2-Clause "Simplified" License
69 stars 44 forks source link

Manual order gives me taxRulesGroupId must be of type int null given error #872

Closed joujou333 closed 8 months ago

joujou333 commented 10 months ago

Expected behavior

Creating the order without error

Actual behavior

Getting error:

Mollie\Provider\TaxCalculatorProvider::getTaxCalculator(): Argument #1 ($taxRulesGroupId) must be of type int, null given, called in /home/wrufwqck/public_html/modules/mollie/src/Provider/PaymentFeeProvider.php on line 88 [TypeError 0]

Steps to reproduce the behavior

In backoffice create a manual order and assign the payment method to Mollie.

Environment

When creating the order as customer as normal, the module works just fine.

joujou333 commented 10 months ago

Sorry, i think i made a issue too soon. Could this be the issue? https://github.com/mollie/PrestaShop/wiki/Order-creation

Because the order is created first instead of the other way around

justelis22 commented 10 months ago

Hi there @joujou333,

We will check this case and get back to you as soon as possible.

Best Regards, Invertus Support team.

justelis22 commented 10 months ago

@joujou333,

We have discussed this internally and it should not be possible to create orders manually from the back office, there are a lot of moving parts, and it would be complex to make the module function in such a way.

Let me know if you have any other questions!

Best Regards, Invertus Support team.

joujou333 commented 10 months ago

Hi @justelis22 ,

Thanks for your rapid response. Ahh I were already afraid of it that it wont work.

Issue can be closed then :)

joujou333 commented 10 months ago

Sorry for reopening the issue. I came across this issue: https://github.com/mollie/PrestaShop/issues/361 So it aint possible anymore due to the order creation order, if im correct?

What does the checkbox do: Send a payment email to customer. Because that is the only thing we want. We just want to send a payment link to the customer

joujou333 commented 10 months ago

I did something nasty to not calculate the paymentfee and tax for it. On file modules/mollie/src/Provider/PaymentFeeProvider.php

I commented the lines 88-115. So the payment fee is always 0, which is not a problem for now. We get the the email and the working payment link, as expected.

justelis22 commented 10 months ago

Hi there @joujou333,

This manual order creation flow is not maintained as it seems. I will have to talk with the Mollie team to see if this is something we will develop. As soon as we have some information, I will post it here.

Best Regards, Invertus Support team.

justelis22 commented 10 months ago

Hi there @joujou333,

We have talked with the Mollie team again and we will fix this feature. The fix is planned to be added to the upcoming release, but if the issue is bigger than expected, we might put it on hold for the next release.

I will inform you regarding updates!

Best Regards, Invertus Support team.

justelis22 commented 8 months ago

Hello there,

The fix was added to 6.1.0.

Best Regards, Invertus Support team.