mariuszsienkiewicz
commented
2 months ago Sorry, it's not just an issue with the number format; it goes much deeper. This is going to be a long comment, so please pay attention.
The method createMollieOrder has a logic issue: if an exception occurs in the first try block:
try {
$apiPayment = $this->createPayment($data, $paymentMethodObj->method);
} catch (Exception $e) {
...
}then this error may be omitted in some cases. The entire code looks like this:
try {
$apiPayment = $this->createPayment($data, $paymentMethodObj->method);
} catch (Exception $e) {
if ($data instanceof OrderData) {
$data->setDeliveryPhoneNumber(null);
$data->setBillingPhoneNumber(null);
}
try {
$apiPayment = $this->createPayment($data, $paymentMethodObj->method);
} catch (OrderCreationException $e) {
$errorHandler = ErrorHandler::getInstance();
$errorHandler->handle($e, HttpStatusCode::HTTP_BAD_REQUEST, true);
} catch (Exception $e) {
$errorHandler = ErrorHandler::getInstance();
$errorHandler->handle($e, HttpStatusCode::HTTP_INTERNAL_SERVER_ERROR, true);
}
}For example, if you use the Klarna Pay Now method, this part of code:
if ($data instanceof OrderData) {
$data->setDeliveryPhoneNumber(null);
$data->setBillingPhoneNumber(null);
}This will remove the delivery and billing phone numbers, and Mollie\DTO\OrderData will change those null values to N/A. Klarna will then respond with the error: Error executing API call (422: Unprocessable Entity): The 'phone' field should contain a valid phone number, in E.164 format. The serialized order data contains "phone":"N\/A", which is, of course, incorrect. The way this code works hides the root cause of the issue with the first createPayment execution.
In my example, this logic hid the error: Error executing API call (422: Unprocessable Entity): The amount of the order does not match the total amount from the order lines. Expected order amount to be €72.14 but got €70.68. That’s why I initially thought there was an issue with the phone number and didn't know the real reason.
Maybe this should be a separate issue, but I'll leave it here for now while I continue debugging.
justelis22
The issue is with Dutch phone numbers.
In the Netherlands, as far as I know, the numbers
0689124321and+31689124321are the same and valid.Unfortunately, both are not transferred correctly to Klarna (I have tested it by using the Pay Now payment method) by the Mollie module, resulting in this error message being shown in the cart: It looks like you have entered an incorrect phone number format in the billing address step. Please change the number and try again.
0689124321from the billing address is transformed (by PhoneNumberProvider::getFromAddress) to+689124321, which is, of course, not valid.+31689124321is left the same and Klarna still doesn't allow it.We are using the current version of the module and PrestaShop 8.1.7.