Missing house number in Klarna; address2 is not passed to Order API

mollie / PrestaShop1.6

BSD 2-Clause "Simplified" License

1 stars 4 forks source link

Missing house number in Klarna; address2 is not passed to Order API #16

Closed muyncky closed 2 years ago

muyncky commented 2 years ago

Expected behavior

When placing an order using the Order API, the address2 is not passed to the delivery address (in for example Klarna). Often this contains the house number. See this address:

The shipping addres, does contain the housenummer (ps_address.address2).

Actual behavior

Pass address2 from the delivery address to the Order API.

Steps to reproduce the behavior

We cannot reproduce in testing mode. Maybe

Place a real order for Klarna
Make sure the delivery address of the order has a value in both address1 and address2.
Checkout the order in Klarna

Environment

PrestaShop version: 1.6.1.24
Mollie module version: 4.5.2
PHP version: 7.2.32

justelis22 commented 2 years ago

Hey there @muyncky,

We will be glad to help you with this! Our team will check your case, and get back to you as soon as possible with an update.

-- Best Regards, Invertus Support team.

muyncky commented 2 years ago

@justelis22 we have a possible fix for this. PR is coming later. Any special requirements for contributing?

justelis22 commented 2 years ago

Hey @muyncky,

Thanks! We have checked the PR, it seems to be very nice, good job! Forwarded this information to the Mollie team, we will communicate internally, and let you know how we can proceed!

Thank you for your patience!

-- Best Regards, Invertus Support team.

justelis22 commented 2 years ago

Hey there @muyncky,

We have merged the PR, and it will be added to the new release of the module, but for now if you don't have it already, you can download it from the GitHub.

We will mark this issue as resolved, but if you have something else to add, don't hesitate to contact us! By the way, thank again for the solution.

Best Regards, Invertus Support team.