search

mollie / WooCommerce

Official Mollie extension for WooCommerce
https://wordpress.org/plugins/mollie-payments-for-woocommerce/
Other
131 stars 53 forks source link

Fix/piwoo 191 psr container scope #824

Closed mmaymo closed 1 year ago

mmaymo commented 1 year ago

Handles PIWOO-191

AlexP11223 commented 1 year ago

I think it's still not all namespace changes? There are at least Psr\Container\ContainerInterface missing.

I would probably Ctrl+Shift+F for Psr\Container and Inpsyde\Modularity.

Ideally we would want to check that via linters. But not sure how, if we install without dev deps we lose psalm too :D

mmaymo commented 1 year ago

hmm, where did you find it missing, I was using the find and replace tool to change the namespaces and now if I run it I get references to Psr\Container within the vendor folder.. but those I will not need to scope, right? cause those are excluded from the build...

AlexP11223 commented 1 year ago

https://github.com/search?q=repo%3Amollie%2FWooCommerce%20Psr%5CContainer&type=code

AlexP11223 commented 1 year ago

ah, yeah, it's changed, didn't notice and thought there would be separate service files with it.