search

mollie / WooCommerce

Official Mollie extension for WooCommerce
https://wordpress.org/plugins/mollie-payments-for-woocommerce/
Other
130 stars 52 forks source link

Upgrade `psr/log` #851

Closed migueldamota closed 10 months ago

migueldamota commented 10 months ago

Hi there,

Would it be possible to include newer versions of psr/log? We encountered this problem today, so we had to downgrade to v1 since some of our features weren't working. It would be great if this would be possible.

Many thanks in advance and have a nice day!

migueldamota commented 10 months ago

Hello again,

Would it be possible to do that? Some kind of reaction would be nice 😅 Should I create a PR for that or do I have to do something else?

Have a nice day!

fjbender commented 10 months ago

Hi Miguel,

We always welcome PRs - if you have tested thoroughly in your setup, the change is highly appreciated :)

InpsydeNiklas commented 10 months ago

Hi folks, one of the reasons this hasn't been done so far is that psr/log version 2.0.0 and newer requires PHP version >=8.0.0. The Mollie plugin currently supports PHP 7.2. The minimum requirement will be raised to PHP 7.4 sometime in the future, but PHP 8 is still a while away since about half of all WordPress websites still run PHP 7.4.

fjbender commented 10 months ago

Ah, unfortunate. Thanks for keeping me in check! Sorry, Miguel!

@asotela3911 for you to give this a final look and probably close.

migueldamota commented 7 months ago

Hello again, I have another quick question about psr/log. Would it be possible to add multiple versions like this:

"require": {
  "psr/log": "^1 || ^2 || ^3"
}

I saw many other packages use this which still support PHP 5. So would it be possible to combine these versions instead of upgrading psr/log fully?

migueldamota commented 7 months ago

@InpsydeNiklas Sorry forgot to mention you, hopefully this reaches you 😄