search

mollie / WooCommerce

Official Mollie extension for WooCommerce
https://wordpress.org/plugins/mollie-payments-for-woocommerce/
Other
129 stars 52 forks source link

Wrap psr/log in namespace #892

Open johanmolen opened 5 months ago

johanmolen commented 5 months ago

This issue is similar as #819.

roots/acorn uses psr/log:^3.0 because of illuminate/log. This raises errors because this package uses ^1.1.4.

Can psr/log be prefixed using Mozart?

johanmolen commented 5 months ago

Also related #883

tombroucke commented 2 months ago

@mmaymo Is this on your roadmap? We have multiple websites waiting to be upgraded, but this issue is blocking the upgrade.

michielgerritsen commented 2 months ago

I just tried to install the Sentry plugin and bumped into this issue as well as it's giving me inheritance errors:

Fatal error: Declaration of Mollie\WooCommerce\Log\WcPsrLoggerAdapter::log($level, $message, array $context = []) must be compatible with Psr\Log\AbstractLogger::log($level, Stringable|string $message, array $context = []): void in /var/www/html/public_html/wp-content/plugins/mollie-payments-for-woocommerce/src/Log/WcPsrLoggerAdapter.php on line 75
InpsydeNiklas commented 2 months ago

Hi folks, we are aware of this dependency conflict and are working on a proper solution for the resulting error. That said, this has a significant impact on the development pipeline, so we can't commit to a timeframe just yet, but we'll let you know when there are any news.

LeanderFS commented 3 weeks ago

@InpsydeNiklas I've opened a PR aiming to fix this issue, could you have a look when time permits please?