Updated gifs because of a visual bug in example 2

mollie / components-examples

Examples and reference implementations for Mollie Components

13 stars 6 forks source link

Updated gifs because of a visual bug in example 2 #2

Closed dejorrit closed 4 years ago

dejorrit commented 4 years ago

@mattijsbliek Updated the gifs for both examples because the second example had a visual bug: placeholder was visible behind the label in the Expiry Date input

mattijsbliek commented 4 years ago

The second file seems incorrect, the placeholder is but on top of the value after you tab out of the field 🤔

dejorrit commented 4 years ago

@mattijsbliek wow, how did I not notice that 😬 Turned out we had a little bug with toggling the is-dirty class, fixed it here: https://github.com/mollie/components-examples/pull/3

mattijsbliek commented 4 years ago

Just merged the other PR. If you can do a new gif I think we’re good to go 🚀

dejorrit commented 4 years ago

@mattijsbliek Gif is updated!