search

mollie / laravel-mollie

Mollie API client wrapper for Laravel & Mollie Connect provider for Laravel Socialite
https://www.mollie.com/
MIT License
322 stars 62 forks source link

Laravel HTTP client #201

Closed Skullbock closed 1 year ago

Skullbock commented 1 year ago

I've written for my project a MollieLaravelHttpClientAdapter that implements MollieHttpAdapterInterface and was wondering if it would make sense to PR it here, and have the ServiceProvider use this new client adapter to make the API calls.

It's useful to me because i can then make use of the Http::fake functionality that Laravel provides to fake outgoing calls to Mollie in my tests.

Alongside this, i also have a Mollie::fake() implementation nearly ready to avoid having to test Mollie in integration every time, while retaining the core functionalities

Thanks!

sandervanhooft commented 1 year ago

Sounds cool, happy to review it!

Skullbock commented 1 year ago

PRed!

Treggats commented 1 year ago

@sandervanhooft can this be included in a new release?

Treggats commented 1 year ago

🙏 Thank you 😄