search

mollie / laravel-mollie

Mollie API client wrapper for Laravel & Mollie Connect provider for Laravel Socialite
https://www.mollie.com/
MIT License
322 stars 62 forks source link

symfony/finder dependency locked to 6.0 #204

Closed tomcoonen closed 1 year ago

tomcoonen commented 1 year ago

Is it intentional that the symfony/finder version is locked to 6.0 instead of ^6.0 in v2.19.2? This blocks using symfony/finder 6.1 in a project.

sandervanhooft commented 1 year ago

Hi @tomcoonen ,

Good catch. Yes, there recently was an issue with Symfony's Finder, therefore the dependency constraint was patched in. We'll investigate the current situation to see if we can expand or remove the current constraint.

Cc @ciungulete

tomcoonen commented 1 year ago

Alright, if you need any testing or help let me know.

ciungulete commented 1 year ago

We lock it currently for 6.0 because symfony/finder 6.1 requires "php": ">=8.1"

tomcoonen commented 1 year ago

@ciungulete Then you can still use '^6.0' in this package since composer won't install 6.1 when you don't have PHP 8.1.

sandervanhooft commented 1 year ago

Looks like it's used by php-cs-fixer and testbench, so we can also try moving it to the list of dev dependencies.

ciungulete commented 1 year ago

Is fixed now

tomcoonen commented 1 year ago

Great, thanks guys!

sandervanhooft commented 1 year ago

Thanks @ciungulete. Enjoy @tomcoonen! And thanks to bringing this to our attention again.