mollie / laravel-mollie

Mollie API client wrapper for Laravel & Mollie Connect provider for Laravel Socialite
https://www.mollie.com/
MIT License
322 stars 62 forks source link

Feature request: Add support for Laravel 10 #218

Closed jnoordsij closed 1 year ago

jnoordsij commented 1 year ago

Add support for Laravel 10, which is expected to be released at February 7th, 2023.

A good starting point might be to look into #183 which added Laravel 9 support and model after that.

LTKort commented 1 year ago

Any idea when Laravel 10 will be supported?

schonhoff commented 1 year ago

Hey!

Would love to see support being added for the package :-) A PR from Laravel Shift ist already there: https://github.com/mollie/laravel-mollie/pull/223

iH8 commented 1 year ago

And the time has come, let's change this issue from feature to bug.

  Problem 1
    - Conclusion: don't install laravel/framework v10.0.0 (conflict analysis result)
    - mollie/laravel-mollie[v2.18.0, ..., v2.21.1] require illuminate/support ^8.0|^9.0 -> satisfiable by illuminate/support[v8.0.0, ..., 8.x-dev, v9.0.0-beta.1, ..., 9.x-dev].
    - mollie/laravel-mollie[v2.11.0, ..., v2.17.0] require illuminate/support ^6.0|^7.0|^8.0 -> satisfiable by illuminate/support[v6.0.0, ..., 6.x-dev, v7.0.0, ..., 7.x-dev, v8.0.0, ..., 8.x-dev].
    - mollie/laravel-mollie[v2.9.0, ..., v2.10.0] require illuminate/support ^5.8.0|^6.0|^7.0 -> satisfiable by illuminate/support[v5.8.0, ..., 5.8.x-dev, v6.0.0, ..., 6.x-dev, v7.0.0, ..., 7.x-dev].
    - mollie/laravel-mollie[v2.7.1, ..., v2.8.0] require illuminate/support ^5.8.0|^6.0 -> satisfiable by illuminate/support[v5.8.0, ..., 5.8.x-dev, v6.0.0, ..., 6.x-dev].
    - mollie/laravel-mollie v2.7.0 requires illuminate/support ^5.5|^6.0 -> satisfiable by illuminate/support[v5.5.0, ..., 5.8.x-dev, v6.0.0, ..., 6.x-dev].
    - mollie/laravel-mollie[v2.0.0-beta1, ..., v2.6.0] require illuminate/support ^5.5 -> satisfiable by illuminate/support[v5.5.0, ..., 5.8.x-dev].
    - Only one of these can be installed: illuminate/support[v5.5.0, ..., 5.8.x-dev, v6.0.0, ..., 6.x-dev, v7.0.0, ..., 7.x-dev, v8.0.0, ..., 8.x-dev, v9.0.0-beta.1, ..., 9.x-dev, v10.0.0, 10.x-dev], laravel/framework[v10.0.0, 10.x-dev]. laravel/framework replaces illuminate/support and thus cannot coexist with it.
    - Root composer.json requires laravel/framework ^10.0 -> satisfiable by laravel/framework[v10.0.0, 10.x-dev].
    - Root composer.json requires mollie/laravel-mollie ^2.0 -> satisfiable by mollie/laravel-mollie[v2.0.0-beta1, ..., v2.21.1].
schonhoff commented 1 year ago

If I get it right they are waiting for this PR to get merged: https://github.com/GrahamCampbell/Laravel-TestBench/issues/29 Hopefully it will be soon but at the moment Mollie is not Laravel 10 compatible.

LTKort commented 1 year ago

I’m using the shift PR and everything seems to be working

sandervanhooft commented 1 year ago

Here you go: https://github.com/mollie/laravel-mollie/releases/tag/v2.22.0.

Enjoy!

sandervanhooft commented 1 year ago

If I get it right they are waiting for this PR to get merged: GrahamCampbell/Laravel-TestBench#29 Hopefully it will be soon but at the moment Mollie is not Laravel 10 compatible.

Indeed @schonhoff, but I decided to apply a workaround for now. Enjoy!

I’m using the shift PR and everything seems to be working

Thanks @LTKort ! Everything worked, except for the tests. All green now. Enjoy the release!

schonhoff commented 1 year ago

Thank you!