mollie / laravel-mollie

Mollie API client wrapper for Laravel & Mollie Connect provider for Laravel Socialite
https://www.mollie.com/
MIT License
322 stars 62 forks source link

Provide laravel 11 compatibiity #238

Closed Naoray closed 6 months ago

Naoray commented 6 months ago

Description

Upgrade to support Laravel v11.

All changes affecting developer using this packages have been documented in https://github.com/mollie/laravel-mollie/blob/provide-laravel-11-compatibiity/UPGRADE.md.

tl;dr;

Types of changes

Checklist:

Todos:

sandervanhooft commented 6 months ago

Thanks @Naoray ! It would be really helpful to list all proposed breaking changes and review/discuss these as part of this PR. Either as a separate upgrade guide document or in the comments here. Especially the Wrapper has received much work that's worth taking a second look at.

jnoordsij commented 6 months ago

Although I must say I'm very much a fan of most of the proposed changes, I do wonder if they should be tied to a major Laravel release. Especially with it being scheduled to release tomorrow and finishing the work on this MR + review process most probably taking a bit longer than that, might it not be more opportunistic to add Laravel 11 support individually (which I think is possible without needing any BC changes looking at #236) and handle the proposed further changes here afterwards?

That also makes it a lot for easy for people looking to upgrade to Laravel 11, given that they can do so without requiring them to also immediately update to the new version of this package all of a sudden.

sandervanhooft commented 6 months ago

Thanks @jnoordsij

We weighed our options and are going with a new major release