Closed dekker7 closed 6 years ago
Same question here, can we expect api v2-support soon? cc @willemstuursma
Thanks guys. It's a bit tricky because we don't have a lot of Laravel experts in house. So it might take us a small while to get this working.
We're willing to hire a freelancer to perform this conversion, so if you are available or know anyone please contact me via email willem@mollie.com. We'd also really like Cashier support.
Update: we've found a freelancer to help us bring this package to full fruition.
I could take care of this, send a e-mail to Willem already 👍
I'm on it! Stay tuned.
@willemstuursma et al
Progress update: Laravel-mollie v2.0.0-beta1
planned for next week.
Most functionality changes have now been implemented in my temporary dev fork. Will need to run some final checks and (re)write the readme file and package migration guide before release.
Some major dependency bumps were required. Php 7.1+, Laravel 5.5+ (LTS), Socialite 3.
Best to maintain a v1 branch as well?
It would be great if you could keep the min. PHP version on 5.6, or the minimum version supported by Laravel, whichever is higher.
@willemstuursma I agree. I'll try to match Laravel 5.5 LTS minimum requirement, PHP 7.0.0.
Yup, LGTM to follow Laravel 5.5 minimum requirements, looking forward to v2.0.0-beta1 next week 👍
@willemstuursma How do you recommend launching the beta?
With a v2.0.0-beta1
tag on the master branch and a link to the migration guide in the release notes? Or should this happen on a separate branch?
I think it is fine to release 2.0.0 straight away, unless you feel uncomfortable with that. Then your approach is fine.
On the master is fine, there won't be many changes to v1 in the future. We can create a v1-develop branch when needed.
PR is ready, but Travis is failing somehow. The fork however is all green (same contents, same travis script). I am communicating with Travis support over mail to resolve this issue.
Finally ironed out the Travis build issues! Will release v2.0.0-beta1
Monday.
Just released v2.0.0-beta1
! See the release notes.
I have scheduled the stable release for next Monday - if all goes well. Fingers crossed!
I tested the v2.0.0-beta1
tag with my Mollie Connect/oAuth app and following the upgrade notes/guide it seems working fine 👍
It only took some time to figure out the testmode options (changes) for payments
$mollie->payments()->get($transactionId . '&testmode=' . $isDevMode);
=>
$mollie->payments()->get($transactionId, [
'testmode' => $isDevMode ? "true" : "false"
]);
Thanks @nickurt !
I'm a bit confused by your $testmode
issue, not familiar with it. Can you elaborate a bit on it?
Is this a Laravel-Mollie specific feature that should be documented in the Laravel-Mollie upgrade guide? Or does it relate to the mollie-api-php client?
This is a specific Connect-only option, in v1 of the api a boolean was allowed, but it seems by v2 it only accept a "true" or "false" as "string", it looks like the docs.mollie.com is not correct here tho, since it said "boolean" is allowed.
I think I can PR it in the https://github.com/mollie/api-documentation repo.
Any reason why it needs this now @willemstuursma, is this due the HAL specification?
If it is passed as part of the query string, it must be the string "true" or "false". Retrieving a payment is a GET operation.
It should be abstracted by the OAuth library, IMHO.
Thanks for clearing that up. As I understand it, there's no need to reference this testMode
change in the Laravel Mollie docs / source.
Correct, I just mentioned b/c I was little bit stuck with it :+1:
Just released v2.0.0 stable! 🎉
Thanks everyone for your input.
Will this library will be updated to the new 2.0 api version of Mollie and https://github.com/mollie/mollie-api-php?
Thanks