search

mollie / magento2-hyva-compatibility

6 stars 6 forks source link

Apple Pay button shows old 'Place Order' text inside of the button #5

Closed jesse-deboer closed 1 year ago

jesse-deboer commented 1 year ago

When you use the direct mode of Apple Pay the Place Order text from inside the button is still visible 'behind' the button of Apple Pay.

Should be fixed like this: https://github.com/mollie/magento2-hyva-compatibility/pull/6

Frank-Magmodules commented 1 year ago

Hi @jesse-deboer , thanks for your PR and for raising this issue. We'll review it along with your pull request and merge it in our upcoming release. Appreciate your patience and contribution!

Frank-Magmodules commented 1 year ago

Hello @jesse-deboer,

The text is hidden using a `font-size: 0`, which in theory should hide the text. Your solution could also work, but when going from Apple Pay back to another method, eg iDeal, the text does not return.

Could you please give us some more context about why this issue occurs in your setup? Could it be that there is some custom CSS interfering?

Thanks!

jesse-deboer commented 1 year ago

Hi @Frank-Magmodules, will be working on this project tomorrow and let you know what was going wrong. It could indeed be some custom CSS overwriting the value.

Frank-Magmodules commented 1 year ago

Sure @jesse-deboer , let me know!

jesse-deboer commented 1 year ago

Closed the PR, it was indeed a custom value. Maybe adding a important tag would help with this?

https://github.com/mollie/magento2-hyva-compatibility/pull/10

Frank-Magmodules commented 1 year ago

Thanks @jesse-deboer , surely we can do that! We will add it to the next release.

Frank-Magmodules commented 1 year ago

Hi There @jesse-deboer , Apologies for the delayed response. The solution has already been incorporated into the release. Please see the specific commit where we included the "!important" here.