mollie / magento2-subscriptions

BSD 2-Clause "Simplified" License
3 stars 5 forks source link

Reminder email timing and filter criteria #50

Closed EFvS closed 1 year ago

EFvS commented 1 year ago

Currently, the reminder email is sent after the payment is due. It should be sent before. $prepaymentDate = (new \DateTimeImmutable())->add($interval); https://github.com/mollie/magento2-subscriptions/blob/main/Cron/SendPrePaymentReminderEmailCron.php#L85

Additionally, the filters for the criteria were incorrect. Currently, you receive every subscription and not just the next one due. $criteria->addFilter('last_reminder_date', $today, 'neq'); https://github.com/mollie/magento2-subscriptions/blob/main/Cron/SendPrePaymentReminderEmailCron.php#L90-L106

Frank-Magmodules commented 1 year ago

Hello @EFvS ,!

Thank you for bringing up this issue and for your patience. I am pleased to inform you that we have successfully resolved the problem, and the fix will be included in our upcoming release scheduled for next week. We greatly appreciate your support and understanding. Thank you!

Frank-Magmodules commented 1 year ago

Hello @EFvS, I appreciate your patience. I'm pleased to inform you that we have resolved the problem you reported in our latest release, version 1.11.0. I will now close this issue, but please don't hesitate to reopen the ticket if necessary. Thank you once again