Closed hostep closed 3 years ago
Hi @hostep, thank you for the detailed issue report. The additional context supplied seems logical and this issue wil be fixed in the next release.
HI @hostep
We are happy to share that we've just released the new 1.24.0 version with a fix for this issue. Thank you again for the detailed issue report. We are closing this issue now but please feel free to reopen the issue if this still occurs.
Describe the bug I'm finding a bunch of PHP fatal errors in the apache error log. At first sight they seem to get triggered by a third party plugin, but I still believe there is a small bug in this module itself. Error:
Used versions
To Reproduce Steps to reproduce the behavior:
$quote
can benull
(default value)$quote->getStoreId()
without checking if$quote
is not nullExpected behavior Fewer errors in the log files
Actual behavior Errors in the log file
Screenshots
Additional context Issue seems to be accidentally created while refactoring this code in https://github.com/mollie/magento2/commit/c61b86535ad3c9c275ec74b2d8cfcc61b580d5ec#diff-0fd68464f7123a24cb46dccf285cf7039dc3f306fa7b8faa89d8d978b8dd6cebL29