Thank you for creating this pull request! To make the best use of your and our time we created this checklist to get the best possible pull requests:
[x] The code is working on a plain Magento 2 installation.
[x] The code follows the PSR-2 code style.
[ ] When an exception or error is logged the message is accompanied with some context, eg: Error when trying to get the payment status:
[ ] Contains tests for the changed/added code (great if so but not required).
[ ] I have added a scenario to test my changes.
This PR touches code in the following areas (Check what is applicable):
Frontend
[ ] Shopping cart
[ ] Checkout
[x] Totals
[ ] Payment methods
Backend
[ ] Configuration
[ ] Order grid
[ ] Order view
[ ] Invoice view
[ ] Credit memo view
[ ] Shipment view
[ ] Email sending
Order Processing (Mollie communication)
[ ] Creating the order
[ ] Invoicing the order
[ ] Shipping the order
[ ] Refunding (credit memo) the order
Other
If you didn't check any boxes above, please describe your changes in this section.
Please describe the bug/feature/etc this PR contains:
This PR fixes the issue https://github.com/mollie/magento2/issues/512 we had when customers were trying to checkout with Klarna Pay Later or Klarna Slice It and had a Fooman Order Fee applied. All credits to @fooman for creating this patch.
Scenario to test this code:
Open the environment and a custom option added by the Fooman Order Fees module. Checkout with one of the Klarna Pay Later methods.
Thank you for creating this pull request! To make the best use of your and our time we created this checklist to get the best possible pull requests:
Error when trying to get the payment status:
This PR touches code in the following areas (Check what is applicable):
Frontend
Backend
Order Processing (Mollie communication)
Other If you didn't check any boxes above, please describe your changes in this section.
Please describe the bug/feature/etc this PR contains:
This PR fixes the issue https://github.com/mollie/magento2/issues/512 we had when customers were trying to checkout with Klarna Pay Later or Klarna Slice It and had a Fooman Order Fee applied. All credits to @fooman for creating this patch.
Scenario to test this code:
Open the environment and a custom option added by the Fooman Order Fees module. Checkout with one of the Klarna Pay Later methods.