mollie / magento2

Mollie Payments for Magento 2
https://www.mollie.com
Other
101 stars 52 forks source link

Set meta title for intermediate loading redirect page #574

Closed HenKun closed 1 year ago

HenKun commented 1 year ago

Describe the bug This is a minor flaw, but simple to fix. The meta title on the "use loading screen" page is empty. This might result in confusion if the customer looks at the history (e.g. long press on mobile back button, or right click on desktop back button). The cutomer might return to the last page that was named "Checkout", instead of to the intermediate page. I propose setting the meta title to "Checkout".

Used versions

To Reproduce Steps to reproduce the behavior:

  1. Go to Checkout
  2. Choose mollie method
  3. Click "Place order"
  4. On the mollie page, have a look at the browser history

Expected behavior The last entry is called "Checkout" or something similar

Actual behavior The last entry is empty, or, if a title suffix is configured, only the title suffix is shown.

Screenshots If applicable, add screenshots to help explain your problem.

Additional context In Controller/Checkout/Redirect.php, after line

$resultPage->getLayout()->getBlock('mollie_loading')->setMollieRedirect($redirectUrl);

add

$resultPage->getConfig()->getTitle()->set(__('Checkout'));
Frank-Magmodules commented 1 year ago

Hi @HenKun ,

We are happy to share that we've just released the new 2.18.0 version where we actually have removed the loading screen as it is obsolete within the later Magento versions.

Thank you for opening this issue and for the detailed issue report.
We are closing this issue now but please feel free to reopen the issue if you still have questions.