Closed Sental closed 1 year ago
Hi @Sental ,
We are happy to share that we've just released the new 2.20.0 version where we have covered this. Thank you for opening this issue together with the detailed steps to reproduce as well as the PR that you have shared! We've added a "Thanks for sharing!" in the release notes as well.
We are closing this issue now but please feel free to reopen the issue if you need any help on this.
@Sental After applying ur PR I can see that the product in the basket in mollie is now of type "digital"... but it looks like that mollie still wants to have digital products shipped - which is not possible in magento:
Order Basket in Mollie:
Order still not completed after shipping all order items in magento:
@simonmaass That is correct. This PR & Issue now sends the correct data to Mollie, a digital product is now marked as digital. This was an issue before the changes in the PR. Mollie themselves have been made aware of this behaviour and that it is not compatible with the Magento platform as standard. Currently I've left it with them to discuss and decide a solution.
HI @Sental and @simonmaass , we've now developed the feature that the digital-product type is marked as shipped on Mollie's side directly after the invoice is created within Magento. Hopefully, this will cover the scenario that @simonmaass had on the non-shipped order line within Mollie. I've personally sent the change to @simonmaass and this will be available for the public within the next release.
Describe the bug Downloadable/Virtual Products in Grouped Products are sent as physical type in the orders api. This requires the product to be shipped for klarna orders to be successfully processed. Shipping a virtual product in magento is impossible.
This also applies for all virtual products that are not shipped.
Used versions
To Reproduce Steps to reproduce the behavior:
Expected behavior The product is set to being type digital and the order is shipped and settled correctly.
Actual behavior The product is set as type physical and the order can never be completely shipped or settled correctly.
Screenshots If applicable, add screenshots to help explain your problem.
Additional context This stops the successful settlement of these orders that pay with klarna pay later. See mollie/magento2/Service/Order/Lines/Order.php L176