mollie / magento2

Mollie Payments for Magento 2
https://www.mollie.com
Other
98 stars 50 forks source link

Quote not restored when Back Button is used #637

Closed HenKun closed 1 year ago

HenKun commented 1 year ago

Describe the bug Since fixing #592 the quote is not restored anymore, if the customer uses the hardware/browser back button on a Mollie related page to return to Magento. This is because the newly created field mollie_success in RestoreQuoteOfUnsuccessfulPayment::execute on line 53 is null. This field is only set to false, if the payment really failed, e.g. after processing or via webhook. I think the use case of hitting the back button occures more often than a customer ordering twice within 5 minutes, so the priority for those both conflicting desires is on the "back button" issue, imho. Alternatively, initializing mollie_success with false could be an option, however, there might be other side effects by doing this which would bypass the fix of #592

Used versions

To Reproduce Steps to reproduce the behavior:

  1. Go to checkout
  2. Choose Mollie payment method
  3. Place Order
  4. On Mollie payment page hit hardware/browser back button (not the "return to payment methods" link)
  5. Cart is empty

Expected behavior Quote is restored and customer is on Checkout Payment Page

Actual behavior Quote is not restored and customer is redirected to empty cart

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here.

Frank-Magmodules commented 1 year ago

Hello @HenKun, we appreciate you creating this clearly outlined problem. We will make an effort to reproduce the issue and address it in the upcoming release. Thank you for your patience!

HenKun commented 1 year ago

Fast as always. You guys make a great job with this module!

Frank-Magmodules commented 1 year ago

Thanks @HenKun , we indeed covered this issue in the latest release, 2.26.0, of the plugin. I will be closing this issue for now. Cheers!