search

mollie / magento2

Mollie Payments for Magento 2
https://www.mollie.com
Other
100 stars 53 forks source link

Billie: A billing organization name is required for this payment method. #640

Closed norgeindian closed 1 year ago

norgeindian commented 1 year ago

Describe the bug When you go to the checkout without entering a company name and try to check out via Billie, you get redirected to the cart and the following error message is shown:

Error executing API call (422: Unprocessable Entity): A billing organization name is required for this payment method. Documentation: https://docs.mollie.com/reference/v2/orders-api/create-order

That is in my eyes not a good way of handling that kind of issue. I would suggest showing a warning like "Please add a billing organization" directly on the check-out page as soon as the customer tries to purchase. With the current way, the customer has to go to the check-out again and also has to actually understand the error message to know what to change.

Used versions

To Reproduce Steps to reproduce the behavior:

  1. Put a random product into the cart
  2. Go to the checkout
  3. Do NOT enter a company in the address fields
  4. Try to check out via Billie

Expected behavior I would expect a warning like "Please add a billing organization" directly on the check-out page as soon as I try to purchase.

Actual behavior I'm getting redirected to the cart and the following error message is shown:

Error executing API call (422: Unprocessable Entity): A billing organization name is required for this payment method. Documentation: https://docs.mollie.com/reference/v2/orders-api/create-order

Screenshots image

Frank-Magmodules commented 1 year ago

Hello @norgeindian, we appreciate you bringing up this issue and providing a clear description. Rest assured that we will look into it and provide a prompt response soon. Thank you.

Frank-Magmodules commented 1 year ago

Hi There @norgeindian, I'm happy to inform you that we have covered this issue in the latest release, 2.26.0, of the plugin. We also added some Cypress test to to avoid issues like this. I will be closing this issue for now. However, please feel free to reopen or comment on the issue if you require any further assistance or have additional feedback. Thank you for your contribution.

norgeindian commented 1 year ago

@Frank-Magmodules , thanks for the fix. Will test and include it and will come back to you, if there are any open issues.

norgeindian commented 1 year ago

@Frank-Magmodules , the error message is lot better now, thanks for the implementation. But there seems to be something wrong with the translation. I added now my translation to our theme translation file, but it's not used. The message still appears in English. Could you please try on your end to provide some translation and check, if that works? Thanks.

norgeindian commented 1 year ago

@Frank-Magmodules , you were right last week. Now I remember, that I bugged you, not Simon ;-) Would you mind taking a look at this issue? Like I wrote, no matter where I add a translation, it's still shown in English. Can you reproduce that on your end?

Frank-Magmodules commented 1 year ago

Ha, I knew it was you @norgeindian ! ;-) I will check this one right away and get back to you shortly.

Frank-Magmodules commented 1 year ago

Hi There @norgeindian , I am happy to inform you that we have recently launched the latest version, v2.29.0, with a fix for your translation issue. I will mark the issue as closed. However, if you encounter any further problems related to this topic, please don't hesitate to reopen it. Thank you for your support!

norgeindian commented 1 year ago

@Frank-Magmodules , unfortunately, my translations of Please enter a company name. are still not taken. This is my csv entry: "Please enter a company name.","Bitte geben Sie einen Firmennamen ein." I fear something is still wrong here. Could you check again on your side please.

norgeindian commented 1 year ago

@Frank-Magmodules , are there any news for this issue?

Frank-Magmodules commented 1 year ago

Hello @norgeindian, it appears that I overlooked this due to the issue being closed. I will make an effort to replicate it promptly and get back to you soon!

Frank-Magmodules commented 1 year ago

Hello @norgeindian! I'm delighted to inform you that we have reevaluated the situation and successfully resolved it permanently in the most recent version. I am closing this issue once more, and I trust it will remain resolved. However, please don't hesitate to reach out if you have any further thoughts or questions.