mollie / magento2

Mollie Payments for Magento 2
https://www.mollie.com
Other
98 stars 49 forks source link

Handle NULL gift wrapping amount case #751

Closed ImanuelBertrand closed 3 months ago

ImanuelBertrand commented 4 months ago

Fixes deprecation notice and subsequent crash in Adobe Commerce Cloud

Thank you for creating this pull request! To make the best use of your and our time we created this checklist to get the best possible pull requests:

This PR touches code in the following areas (Check what is applicable):

Frontend

Backend

Order Processing (Mollie communication)

Other If you didn't check any boxes above, please describe your changes in this section.

Please describe the bug/feature/etc this PR contains:

When I tried to check out (in Adobe Commerce Cloud hosting), the process crashed with a deprecation notice.

Scenario to test this code:

Open the environment and check out without using gift wrapping.

Frank-Magmodules commented 4 months ago

Hi There @ImanuelBertrand , Thank you for the Pull Request! We'll review and test it, and once approved, we'll include it in the upcoming release.

ryan-copeland commented 3 months ago

@Frank-Magmodules We too are experiencing this same issue. Please can we look to get this merged.

Frank-Magmodules commented 3 months ago

Hello @ryan-copeland, we've previously discussed this PR on Slack, but it's good to bring it up publicly as well. Rest assured, we'll incorporate this PR into our review process and merge it once approved for the next release.

ryan-copeland commented 3 months ago

Thanks @Frank-Magmodules ! Now get back to your sunbed and enjoy your holiday!😁

Frank-Magmodules commented 3 months ago

Hi @ryan-copeland and @ImanuelBertrand , to formally close this PR, we'd like to confirm that we've incorporated it into our latest release. Thank you for your valuable contribution; it's greatly appreciated!

ryan-copeland commented 3 months ago

Thanks for the speedy turn around @Frank-Magmodules