Closed sprankhub closed 3 weeks ago
HI There @sprankhub ! We already had a short talk on this but again, thank you for opening this issue. The methods are enabled by default for a few different reasons, but mainly to make it easier for merchants to get up & running faster.
Next to that, if I remember correctly there was also a reason for this to be on by default when Magento 2.4.0 came out, but I might be wrong there. Anyway, we are going to leave this as-is for now. As the whole payment methods config page might be revisited in a later stadium anyway.
Thanks anyway!
Thanks for the feedback. I really hope you'll change this later in the process, as I think this is a no-go :see_no_evil:
Hi There @sprankhub , Can you tell me why this is a direct no-go? I agree that the improvement is an improvement indeed, but we don't want to risk enabling or disabling methods for clients by modifying these setup/upgrade scripts for now. Thanks for sharing of course and, we'll take your improvement when we revisit the payment configuration page!
I gave some reasoning in my initial issue description already :) I don't think there should be any upgrade scripts. I think only the default values in the XML should be false
.
By default, many payment methods are active by default. Examples:
https://github.com/mollie/magento2/blob/f2ac6c285b09dc4e71eccb4665414a34a121921b/etc/config.xml#L75
https://github.com/mollie/magento2/blob/f2ac6c285b09dc4e71eccb4665414a34a121921b/etc/config.xml#L94
https://github.com/mollie/magento2/blob/f2ac6c285b09dc4e71eccb4665414a34a121921b/etc/config.xml#L113
This shouldn't be the case as usually, clients only use a small subset of the available payment methods. Also, when the extension is first configured and the API credentials are entered, still no payment methods should be shown unless I deliberately enable some.