Support applepay validation

mollie / mollie-api-node

Official Mollie API client for Node

http://www.mollie.com

BSD 3-Clause "New" or "Revised" License

238 stars 63 forks source link

Support applepay validation #193

Closed hobadams closed 3 years ago

hobadams commented 3 years ago

I've tried to add support for the ApplePay session method - https://docs.mollie.com/reference/v2/wallets-api/request-apple-pay-payment-session

I've not been able to test because this method is not available in test mode.

I'd love some feedback if you're able to provide it

hobadams commented 3 years ago

@Pimm - Are you the best person to request a review from?

hobadams commented 3 years ago

@Pimm - Thanks so much for looking at this so quickly.

Pimm commented 3 years ago

Thank you for the contribution!

I changed your PR in two ways:

I renamed the method to requestPaymentSession to match the documentation, and
I made ApplePaySessionData not inherit from Model, as the object does not actually have an id and resource property like most objects returned by the API do.

It is unfortunate that we can't test this in the way we test the other endpoints.

hobadams commented 3 years ago

Awesome, thanks so much @Pimm. Do you think this will make it's way into your next release?

Pimm commented 3 years ago

Yes!

hobadams commented 3 years ago

@edorivai - good idea. I'll be using it with our Mollie / Deity (https://deity.io/) integration so it should get heavily tested.

hobadams commented 3 years ago

@Pimm @edorivai - I've just tested the merged code using production Mollie credentials and it's returning the data I expected. I've still got a little way before I have a full integration working in my app to show you but this works well.

Thanks!

Pimm commented 3 years ago

To hopefully make your job slightly easier, you can now use the version with the beta dist tag (using npm install @mollie/api-client@beta). It reflects master at this point in time, and includes your contribution.

Should you run into any issues while integrating Mollie ‒ including anything not Apple Pay related ‒ please let me know.

hobadams commented 3 years ago

@Pimm I've put live ApplePay transactions through Mollie using the beta branch so I can confirm it works :-)