search

mollie / mollie-api-node

Official Mollie API client for Node
http://www.mollie.com
BSD 3-Clause "New" or "Revised" License
228 stars 62 forks source link

The new 'Terminals' API #328

Open Jeffrey-Zutt opened 10 months ago

Jeffrey-Zutt commented 10 months ago

Hello!

First off all, thanks for maintaining this great library :-).

I was wondering if there are any plans of integrating the new 'terminals' API into this library. https://docs.mollie.com/reference/v2/terminals-api/overview

Happy to help and raise a PR on it.

fjbender commented 10 months ago

Thanks for reaching out! We're always happy to take contributions :)

Once the resource issue on the Terminal API is covered, let's take another look at this.

Jeffrey-Zutt commented 10 months ago

Yeah I noticed that too, the resource property is missing from the actual API response right? (Even though it's documented here: https://docs.mollie.com/reference/v2/terminals-api/get-terminal#response)

Do you happen to have any idea when this issue will be covered? (Ballpark?)

fjbender commented 10 months ago

I have just been informed that one of our fantastic engineers has fixed it already :) Should be available very shortly.

if you were to provide a PR, @Pimm and I would be very happy, I'm sure. I will be out of the office for a while, but @Jonas4Mollie will keep watch.

Jeffrey-Zutt commented 10 months ago

Awesome! I'll keep you posted :-)

Jonas4Mollie commented 10 months ago

The resource parameter is now part of the API response, so you should be able to move ahead!

iFlyinq commented 3 months ago

Any updates on this one?