search

mollie / mollie-api-node

Official Mollie API client for Node
http://www.mollie.com
BSD 3-Clause "New" or "Revised" License
228 stars 62 forks source link

Add cancelUrl in payment.create as specified in the documentation #332

Open Alexandregirbal opened 9 months ago

Alexandregirbal commented 9 months ago

In the documentation of the Create payment route there is an optional paramter named cancelUrl. It is not a parameter of the payments.create method in this client.

madhums commented 9 months ago

Yes, much needed.

Alexandregirbal commented 8 months ago

I had another look and this have been fix with PR #327 which was merged on master on the 27th of September. Unfortunately the NPM package wasn't published for 7 months now. @Pimm or @vernondegoede any news for a release date on npm? 😄 Maybe we should build the client locally until then ?

fjbender commented 8 months ago

Indeed, I think a fresh release would be in order. @Pimm would you feel comfortable tagging the current state as a new release? The change set looks quite serious.

Alexandregirbal commented 6 months ago

@Pimm Any news about this topic? otherwise the npm package is useless to many of us I guess as the issue forces us to use the raw api.

fjbender commented 6 months ago

@janpaepke , @Pimm , @maria-swierblewska , and I are currently solving Node version compatibility in #338 (as that also has connections to an Axios CVE). After that is solved, I'm confident we'll be able to push out a release soon.

Alexandregirbal commented 6 months ago

Ok thanks a lot!