fix: add missing status type

mollie / mollie-api-node

Official Mollie API client for Node

http://www.mollie.com

BSD 3-Clause "New" or "Revised" License

235 stars 63 forks source link

fix: add missing status type #335

Closed casperiv0 closed 7 months ago

casperiv0 commented 11 months ago

This PR includes::

Add missing status field for getting the payment methods.

janpaepke commented 8 months ago

Hi @casperiv0, I would suggest this to be an enum, similar to PaymentStatus or OrderStatus. Would you mind updating the pr?

casperiv0 commented 8 months ago

@janpaepke done!

janpaepke commented 8 months ago

lgtm

@fjbender @Pimm we should merge this before doing the major release.

edorivai commented 7 months ago

@casperiv0 We've about to issue a major version bump as per https://github.com/mollie/mollie-api-node/pull/338. Would you be able to update to the newer version once it's cut? Planning to cut this week.

New version will require Node >= 14.

If something is blocking you from updating we could backport to the current major.

casperiv0 commented 7 months ago

Sure! I'm be able to update to the newer version once it's out. Though, to confirm, you simply mean here: rebase my PR from the master/main branch, right?