search

mollie / mollie-api-node

Official Mollie API client for Node
http://www.mollie.com
BSD 3-Clause "New" or "Revised" License
235 stars 63 forks source link

update required node version [breaking] #341

Closed janpaepke closed 7 months ago

janpaepke commented 8 months ago

In accordance with the discussion here, this raises the minimum node version for the package to node 14.

It also updates some github actions versions (which should have no effect).

The CI is now also configured to run on node 20.

This update will require the repo settings to be updated to expect the correct checks.

fjbender commented 8 months ago

I adjusted the branch protection rules to reflect the pipeline changes.

Do you want another review, maybe from @Pimm ?

maria-swierblewska commented 8 months ago

Hi @Pimm is it possible for you to review this change?

maria-swierblewska commented 7 months ago

Hi @janpaepke this update is showing up as a vulnerability for one of our important integrations, could we skip a second review and merge together with https://github.com/mollie/mollie-api-node/pull/338#issuecomment-1891541701?

janpaepke commented 7 months ago

As @pimm has been the primary maintainer for a long time I would feel more comfortable with him taking a look. It's not so much about the implementation, but there might be unforeseen side effects implied by a node version bump, which only he might know.

I also know that he's a bit preoccupied at the moment. But I'll reach out directly and try to point him towards this.

maria-swierblewska commented 7 months ago

@janpaepke understood, since we're getting a bit pressured on time I'll appreciate an update whenever you talk to Pimm!