search

mollie / mollie-api-node

Official Mollie API client for Node
http://www.mollie.com
BSD 3-Clause "New" or "Revised" License
240 stars 64 forks source link

Missing endpoint payments of payment-links #381

Open mattickx opened 1 month ago

mattickx commented 1 month ago

Add missing endpoint https://api.mollie.com/v2/payment-links/{id}/payments to the mollie node client.

Docs: https://docs.mollie.com/reference/get-payment-link-payments

Related discord topics: https://discord.com/channels/1037712581407817839/1288507180122640456 https://discord.com/channels/1037712581407817839/1288137318691242058 https://discord.com/channels/1037712581407817839/1166419761060646942 https://discord.com/channels/1037712581407817839/1057291926786801735

As requested by Flo on discord, adding it here as an issue to keep track of it.

Maybe worth it to document which endpoints are missing. Or at least implement it with a throw throw new Error('Not yet implemented')

fjbender commented 1 month ago

Maybe possible to squeeze in https://github.com/mollie/mollie-api-node/milestone/6, too @Pimm?

janpaepke commented 1 month ago

The main extension currently for 4.2.0 is the addition of the terminals API. This one is far more extensive but it still might make sense to do it in the same release. I will mark it for 4.2.0 for now, but suggest to bump it to 4.3.0 if this turns out to significantly delay the release.

Please also be advised that there is currently no fixed schedule for 4.2.0

@mattickx: We strive to keep the client as up to date as possible. The added overhead of managing missing or disabled endpoints in the code often is on par or even exceeds the efforts needed to just implement them for real. This is why we generally try to avoid this.

ottob commented 1 month ago

Any updates on this? Im playing around with payment links. I expected the web hook call after a link payment to include the status of the payment. But it looks like I only got an id; id: "pl_P1Otwp9bBydYonLczRHc4" is that intentional? So the idea is that the hook will fire and then I should fetch the payment status?

Im used to stripe links where I could create a single link (that would collect the customer email, and the email could be prefilled with a query parameter like ?prefilled_email=...) then when the web hook fired I could see both the payment status and the email of the customer. Could this scenario be accomplished using mollie? Right now I create a payment link for each payment. That doesn't feel correct when there is thousands of payments.

fjbender commented 1 month ago

We are currently still working on getting this done, either for the upcoming 4.2.0 release or the 4.3.0 release the latest.

is that intentional?

Yes. As we send webhook payloads unsigned and unencrypted, this is for security reasons.

I think there is nothing wrong with creating as many payment links as you need :)